fix: fix deep sensitive redaction#43
Merged
Merged
Conversation
ccharly
force-pushed
the
cc/fix/fix-deep-sensitive
branch
from
July 15, 2026 20:08
d780b98 to
8d3c281
Compare
ccharly
force-pushed
the
cc/fix/fix-deep-sensitive
branch
from
July 15, 2026 20:08
8d3c281 to
94370f0
Compare
hmalik88
reviewed
Jul 16, 2026
hmalik88
reviewed
Jul 16, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c86b4f4. Configure here.
hmalik88
previously approved these changes
Jul 16, 2026
ccharly
enabled auto-merge (squash)
July 16, 2026 14:58
hmalik88
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ancestor branches were still able to keep a reference to the original data that was not redacted, resulting in potentially leaking the sensitive data using custom failure reporting.
Note
Medium Risk
Changes sensitive-data redaction in error branches; incorrect ancestor patching could still leak secrets or alter failure shapes for custom reporters.
Overview
Fixes a leak where sibling-field validation failures could still expose sensitive values on outer entries in
failure.branch, because ancestors kept live references to the unredacted child object.withRedactedBranchnow redacts the matched parent, then walks ancestors backward, copying each level and swapping the child reference for the already-sanitized branch entry. Plain objects, arrays, and Maps are handled separately.Adds validation fixtures for nested objects, deep nesting, array-wrapped secrets, and Map-wrapped secrets.
Reviewed by Cursor Bugbot for commit 4e88633. Bugbot is set up for automated code reviews on this repo. Configure here.